Checkstyle Results

The following document contains the results of Checkstyle 6.11.2 with checkstyle.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
155 0 103 0

Files

File  I  W  E
org/jxpfw/demo/ajax/Ajax102Servlet.java 0 3 0
org/jxpfw/demo/lang/ConstructionOrder.java 0 8 0
org/jxpfw/demo/servlet/BasicCsvServlet.java 0 1 0
org/jxpfw/ejb/CompoundEJBException.java 0 2 0
org/jxpfw/ejb/CreateEJBException.java 0 1 0
org/jxpfw/ejb/FindEJBException.java 0 1 0
org/jxpfw/ejb/LookupCMPEntityEJB.java 0 1 0
org/jxpfw/ejb/RemoveEJBException.java 0 1 0
org/jxpfw/ejb/UpdateEJBException.java 0 1 0
org/jxpfw/ejb/ValueObject.java 0 1 0
org/jxpfw/jsp/AbstractJSPBean.java 0 26 0
org/jxpfw/jsp/CTree.java 0 4 0
org/jxpfw/jsp/CTreeItem.java 0 1 0
org/jxpfw/jsp/CTreeItemAdornment.java 0 1 0
org/jxpfw/jsp/LoginJSPBean.java 0 2 0
org/jxpfw/jsp/tag/GenericExceptionsTag.java 0 4 0
org/jxpfw/jsp/tag/GenericMessagesTag.java 0 1 0
org/jxpfw/jsp/tag/TreeTag.java 0 2 0
org/jxpfw/jsp/tag/debug/DebugInfoTag.java 0 5 0
org/jxpfw/jsp/tag/form/AbstractFormElementTag.java 0 1 0
org/jxpfw/jsp/tag/form/AbstractInputTag.java 0 1 0
org/jxpfw/jsp/tag/form/CheckBoxTag.java 0 1 0
org/jxpfw/jsp/tag/form/FormTag.java 0 3 0
org/jxpfw/jsp/tag/form/RadioButtonTag.java 0 1 0
org/jxpfw/jsp/tag/form/SelectTag.java 0 4 0
org/jxpfw/jsp/tag/format/ResourceBundleLabelTag.java 0 1 0
org/jxpfw/jsp/tag/format/ResourceBundleTag.java 0 1 0
org/jxpfw/jsp/tag/format/SplitPageTag.java 0 1 0
org/jxpfw/servlet/AutoCompleteServlet.java 0 2 0
org/jxpfw/servlet/CHttpServlet.java 0 1 0
org/jxpfw/util/AbstractCsvWriter.java 0 2 0
org/jxpfw/util/JNDIUtil.java 0 1 0
org/jxpfw/util/WebLogicUtil.java 0 17 0

Rules

Category Rule Violations Severity
coding DeclarationOrder 6  Warning
IllegalCatch 32  Warning
IllegalType
  • tokens: "METHOD_DEF,PARAMETER_DEF,VARIABLE_DEF"
 1  Warning
MagicNumber
  • constantWaiverParentToken: "TYPECAST,METHOD_CALL,EXPR,ARRAY_INIT,UNARY_MINUS,UNARY_PLUS,ELIST,STAR,ASSIGN,PLUS,MINUS,DIV,LITERAL_NEW"
  • ignoreNumbers: "-1, 0, 1, 2, 10"
 2  Warning
MultipleStringLiterals
  • allowedDuplicates: "5"
 5  Warning
OverloadMethodsDeclarationOrder 1  Warning
ReturnCount 2  Warning
design MutableException 1  Warning
OneTopLevelClass 2  Warning
imports ImportOrder
  • ordered: "true"
  • sortStaticImportsAlphabetically: "true"
  • separated: "true"
  • option: "above"
 1  Warning
UnusedImports 1  Warning
javadoc JavadocMethod
  • suppressLoadErrors: "true"
 1  Warning
JavadocParagraph 1  Warning
JavadocStyle 2  Warning
metrics BooleanExpressionComplexity 2  Warning
ClassDataAbstractionCoupling 1  Warning
ClassFanOutComplexity 1  Warning
CyclomaticComplexity 2  Warning
JavaNCSS 2  Warning
modifier RedundantModifier 1  Warning
naming AbstractClassName 5  Warning
MethodName 7  Warning
sizes AnonInnerLength 1  Warning
ExecutableStatementCount
  • tokens: "INSTANCE_INIT,STATIC_INIT,METHOD_DEF,CTOR_DEF"
 4  Warning
LineLength
  • max: "128"
  • tabWidth: "4"
 1  Warning
MethodLength
  • max: "100"
 2  Warning
OuterTypeNumber 1  Warning
ParameterNumber
  • max: "3"
 14  Warning
whitespace EmptyLineSeparator 1  Warning

Details

org/jxpfw/demo/ajax/Ajax102Servlet.java

Severity Category Rule Message Line
 Warning sizes ExecutableStatementCount Executable statement count is 118 (max allowed is 30). 48
 Warning sizes MethodLength Method length is 120 lines (max allowed is 100). 48
 Warning metrics JavaNCSS NCSS for this method is 119 (max allowed is 50). 48

org/jxpfw/demo/lang/ConstructionOrder.java

Severity Category Rule Message Line
 Warning sizes OuterTypeNumber Outer types defined is 3 (max allowed is 1). 19
 Warning design OneTopLevelClass Top-level class SuperClass has to reside in its own source file. 142
 Warning coding DeclarationOrder Static variable definition in wrong order. 153
 Warning coding DeclarationOrder Static variable definition in wrong order. 172
 Warning design OneTopLevelClass Top-level class SubClass has to reside in its own source file. 217
 Warning coding DeclarationOrder Static variable definition in wrong order. 228
 Warning coding DeclarationOrder Static variable definition in wrong order. 247
 Warning modifier RedundantModifier Redundant 'public' modifier. 260

org/jxpfw/demo/servlet/BasicCsvServlet.java

Severity Category Rule Message Line
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 67

org/jxpfw/ejb/CompoundEJBException.java

Severity Category Rule Message Line
 Warning design MutableException The field 'functionalException' must be declared final. 56
 Warning sizes ParameterNumber More than 3 parameters (found 4). 95

org/jxpfw/ejb/CreateEJBException.java

Severity Category Rule Message Line
 Warning sizes ParameterNumber More than 3 parameters (found 4). 88

org/jxpfw/ejb/FindEJBException.java

Severity Category Rule Message Line
 Warning sizes ParameterNumber More than 3 parameters (found 4). 88

org/jxpfw/ejb/LookupCMPEntityEJB.java

Severity Category Rule Message Line
 Warning naming AbstractClassName Name 'LookupCMPEntityEJB' must match pattern '^Abstract.+$'. 34

org/jxpfw/ejb/RemoveEJBException.java

Severity Category Rule Message Line
 Warning sizes ParameterNumber More than 3 parameters (found 4). 89

org/jxpfw/ejb/UpdateEJBException.java

Severity Category Rule Message Line
 Warning sizes ParameterNumber More than 3 parameters (found 4). 145

org/jxpfw/ejb/ValueObject.java

Severity Category Rule Message Line
 Warning naming AbstractClassName Name 'ValueObject' must match pattern '^Abstract.+$'. 36

org/jxpfw/jsp/AbstractJSPBean.java

Severity Category Rule Message Line
 Warning imports UnusedImports Unused import - java.util.MissingResourceException. 34
 Warning imports ImportOrder Wrong order for 'com.oreilly.servlet.MultipartRequest' import. 61
 Warning metrics ClassDataAbstractionCoupling Class Data Abstraction Coupling is 9 (max allowed is 7) classes [CResourceBundle, Cookie, DefaultFileRenamePolicy, File, FileRenamePolicy, InitialContext, JSPPropertyFormatter, Message, MultipartRequest]. 86
 Warning metrics ClassFanOutComplexity Class Fan-Out Complexity is 32 (max allowed is 20). 86
 Warning coding DeclarationOrder Variable access definition in wrong order. 120
 Warning coding DeclarationOrder Variable access definition in wrong order. 126
 Warning sizes LineLength Line is longer than 128 characters (found 137). 458
 Warning coding MultipleStringLiterals The String "key" appears 6 times in the file. 534
 Warning whitespace EmptyLineSeparator ';' should be separated from previous statement. 865
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 1086
 Warning javadoc JavadocMethod Expected @throws tag for 'IOException'. 1133
 Warning naming MethodName Name '_init' must match pattern '^[a-z][a-zA-Z0-9]*$'. 1158
 Warning naming MethodName Name '_processFirstPass' must match pattern '^[a-z][a-zA-Z0-9]*$'. 1171
 Warning naming MethodName Name '_processSubsequentPass' must match pattern '^[a-z][a-zA-Z0-9]*$'. 1185
 Warning naming MethodName Name '_processEveryPass' must match pattern '^[a-z][a-zA-Z0-9]*$'. 1199
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '306'. 1215
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 1222
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 1338
 Warning javadoc JavadocStyle Extra HTML tag found: </td> 1367
 Warning javadoc JavadocStyle Extra HTML tag found: </td> 1368
 Warning naming MethodName Name '_isSessionValid' must match pattern '^[a-z][a-zA-Z0-9]*$'. 1672
 Warning coding MagicNumber '1000' is a magic number. 1717
 Warning metrics CyclomaticComplexity Cyclomatic Complexity is 14 (max allowed is 10). 1847
 Warning sizes ExecutableStatementCount Executable statement count is 32 (max allowed is 30). 1847
 Warning sizes MethodLength Method length is 119 lines (max allowed is 100). 1847
 Warning sizes AnonInnerLength Anonymous inner class length is 42 lines (max allowed is 20). 1858

org/jxpfw/jsp/CTree.java

Severity Category Rule Message Line
 Warning sizes ParameterNumber More than 3 parameters (found 4). 115
 Warning sizes ParameterNumber More than 3 parameters (found 5). 137
 Warning coding ReturnCount Return count is 4 (max allowed is 2). 414
 Warning coding ReturnCount Return count is 4 (max allowed is 2). 445

org/jxpfw/jsp/CTreeItem.java

Severity Category Rule Message Line
 Warning sizes ParameterNumber More than 3 parameters (found 4). 138

org/jxpfw/jsp/CTreeItemAdornment.java

Severity Category Rule Message Line
 Warning naming AbstractClassName Name 'CTreeItemAdornment' must match pattern '^Abstract.+$'. 28

org/jxpfw/jsp/LoginJSPBean.java

Severity Category Rule Message Line
 Warning naming MethodName Name 'setJ_username' must match pattern '^[a-z][a-zA-Z0-9]*$'. 65
 Warning naming MethodName Name 'setJ_password' must match pattern '^[a-z][a-zA-Z0-9]*$'. 76

org/jxpfw/jsp/tag/GenericExceptionsTag.java

Severity Category Rule Message Line
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 129
 Warning sizes ParameterNumber More than 3 parameters (found 4). 204
 Warning sizes ParameterNumber More than 3 parameters (found 4). 240
 Warning sizes ParameterNumber More than 3 parameters (found 4). 277

org/jxpfw/jsp/tag/GenericMessagesTag.java

Severity Category Rule Message Line
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 114

org/jxpfw/jsp/tag/TreeTag.java

Severity Category Rule Message Line
 Warning coding MultipleStringLiterals The String ", " appears 11 times in the file. 288
 Warning sizes ExecutableStatementCount Executable statement count is 36 (max allowed is 30). 317

org/jxpfw/jsp/tag/debug/DebugInfoTag.java

Severity Category Rule Message Line
 Warning metrics BooleanExpressionComplexity Boolean expression complexity is 5 (max allowed is 3). 119
 Warning coding MultipleStringLiterals The String "Method" appears 6 times in the file. 185
 Warning coding MultipleStringLiterals The String "Value" appears 15 times in the file. 185
 Warning sizes ExecutableStatementCount Executable statement count is 58 (max allowed is 30). 286
 Warning metrics JavaNCSS NCSS for this method is 61 (max allowed is 50). 286

org/jxpfw/jsp/tag/form/AbstractFormElementTag.java

Severity Category Rule Message Line
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 109

org/jxpfw/jsp/tag/form/AbstractInputTag.java

Severity Category Rule Message Line
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 286

org/jxpfw/jsp/tag/form/CheckBoxTag.java

Severity Category Rule Message Line
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 106

org/jxpfw/jsp/tag/form/FormTag.java

Severity Category Rule Message Line
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 298
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 347
 Warning coding MagicNumber '32' is a magic number. 407

org/jxpfw/jsp/tag/form/RadioButtonTag.java

Severity Category Rule Message Line
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 79

org/jxpfw/jsp/tag/form/SelectTag.java

Severity Category Rule Message Line
 Warning javadoc JavadocParagraph Javadoc comment at column 4 has parse error. Unrecognized error from ANTLR parser: null 287
 Warning metrics CyclomaticComplexity Cyclomatic Complexity is 11 (max allowed is 10). 295
 Warning metrics BooleanExpressionComplexity Boolean expression complexity is 6 (max allowed is 3). 304
 Warning sizes ParameterNumber More than 3 parameters (found 4). 383

org/jxpfw/jsp/tag/format/ResourceBundleLabelTag.java

Severity Category Rule Message Line
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 123

org/jxpfw/jsp/tag/format/ResourceBundleTag.java

Severity Category Rule Message Line
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 88

org/jxpfw/jsp/tag/format/SplitPageTag.java

Severity Category Rule Message Line
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 206

org/jxpfw/servlet/AutoCompleteServlet.java

Severity Category Rule Message Line
 Warning naming AbstractClassName Name 'AutoCompleteServlet' must match pattern '^Abstract.+$'. 44
 Warning coding IllegalType Declaring variables, return values or parameters of type 'TreeSet' is not allowed. 60

org/jxpfw/servlet/CHttpServlet.java

Severity Category Rule Message Line
 Warning naming AbstractClassName Name 'CHttpServlet' must match pattern '^Abstract.+$'. 44

org/jxpfw/util/AbstractCsvWriter.java

Severity Category Rule Message Line
 Warning sizes ParameterNumber More than 3 parameters (found 4). 197
 Warning sizes ParameterNumber More than 3 parameters (found 4). 232

org/jxpfw/util/JNDIUtil.java

Severity Category Rule Message Line
 Warning coding IllegalCatch Catching 'RuntimeException' is not allowed. 137

org/jxpfw/util/WebLogicUtil.java

Severity Category Rule Message Line
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 220
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 262
 Warning coding MultipleStringLiterals The String "name" appears 6 times in the file. 288
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 298
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 330
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 353
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 380
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 405
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 429
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 452
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 479
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 509
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 538
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 569
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 631
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 656
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 677